Skip to content

Iss 507 support filter clause #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2022
Merged

Iss 507 support filter clause #617

merged 3 commits into from
Oct 1, 2022

Conversation

@ahmad-moussawi
Copy link
Contributor

@ahmad-moussawi ahmad-moussawi commented Oct 1, 2022 •
edited
Loading

This PR adds the support for the SelectAggregate method and it's siblings SelectSum, SelectMax, SelectMin, SelectAvg, SelectCount methods, this is better than using SelectRaw.

All these methods accepts an optional filter parameter to filter the aggregated column based on a specified conditions, this will translate to the Aggregation Filter clause on supported compilers like PostgreSQL, and SQLite with a fallback to CASE WHEN statement for the unsupported ones.

Related #507

@ahmad-moussawi ahmad-moussawi merged commit 31ee1e0 into master Oct 1, 2022
@ahmad-moussawi ahmad-moussawi deleted the iss-507_support_filter_clause branch October 1, 2022 06:58
@ahmad-moussawi ahmad-moussawi mentioned this pull request Oct 2, 2022
Closed
@yankyhgoflow
Copy link
Contributor

yankyhgoflow commented Oct 3, 2022

👍 Thanks, this is really taking this library to the next level!

Thanks @ahmad-moussawi you rock!

@kenzouno1
Copy link

kenzouno1 commented Nov 19, 2022

Missing alias for this feature

@ahmad-moussawi
Copy link
Contributor Author

ahmad-moussawi commented Nov 19, 2022

@kenzouno1 what do you mean exactly by missing alias? is this what you are looking for?

var query = db.Query("Transaction")
                .SelectSum("Amount as Total_2020", q => q.WhereDatePart("year", "date", 2020))
                .SelectSum("Amount as Total_2021", q => q.WhereDatePart("year", "date", 2021))
                .SelectSum("Amount as Total_2022", q => q.WhereDatePart("year", "date", 2022))

check more examples here
https://github.com/sqlkata/querybuilder/blob/master/QueryBuilder.Tests/MySqlExecutionTest.cs#L237

@kenzouno1
Copy link

kenzouno1 commented Nov 23, 2022

That's exactly what I'm looking for. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahmad-moussawi @yankyhgoflow @kenzouno1